On 09/24/2014 11:42 AM, H. Peter Anvin wrote: > On 09/24/2014 09:07 AM, Bryan O'Donoghue wrote: >>> >>> So __flush_tlb_all(); will do nothing but that's OK since load_cr3() >>> already flushed the TLB - including any PTE with PGE set >> >> I take your point though. >> >> It's probably better to be explicit and do the whole >> >> if (quark) >> __flush_tlb(); >> else >> __flush_tlb_all(); >> >> So that we aren't relying on the side effects of the previous statement. >> > > Well, we need a comment at least. > And certainly we don't need an if/else as we can just do it. -hpa -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html