Re: [LTSI-dev] [GIT PULL LTSI-3.14] Renesas SoCs and Drivers to v3.16

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon, Greg,

On Tue, Sep 16, 2014 at 3:36 AM, Simon Horman
<horms+renesas@xxxxxxxxxxxx> wrote:
> Please consider these Renesas backports for LTSI-3.14.
> It brings all of the following components up to their standard
> as of v3.16, building on previous work to bring them up to their
> standard as of v3.15. It also includes dependencies as necessary.
> The components other than mach-shmobile are all drivers.

>       pwm: add period and polarity to struct pwm_lookup

Sorry for missing this in your previous mail, but this introduces a regression,
for which a fix is available:

commit d717ea73e36dd5659640fae82605ad85c4117f4d
Author: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Date:   Wed Aug 13 17:18:53 2014 +0200

    pwm: Fix period and polarity in pwm_get() for non-perfect matches

    If pwm_get() finds a look-up entry with a perfect match (both dev_id and
    con_id match), the loop is aborted, and "p" still points to the correct
    struct pwm_lookup.

    If only an entry with a matching dev_id or con_id is found, the loop
    terminates after traversing the whole list, and "p" now points to
    arbitrary memory, not part of the pwm_lookup list.
    Then pwm_set_period() and pwm_set_polarity() will set random values for
    period resp. polarity.

    To fix this, save period and polarity when finding a new best match,
    just like is done for chip (for the provider) and index.

    This fixes the LCD backlight on r8a7740/armadillo-legacy, which was fed
    period 0 and polarity -1068821144 instead of 33333 resp. 1.

    Fixes: 3796ce1d4d4b ("pwm: add period and polarity to struct pwm_lookup")
    Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
    Cc: stable@xxxxxxxxxxxxxxx
    Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxx>

Despite its inclusion in v3.17-rc2 and the CC to stable, this doesn't seem
to have been included in v3.16.x yet.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]