On Sat, Dec 03, 2022 at 05:36:55PM -0500, Steven Rostedt wrote:
> On Sat, 03 Dec 2022 12:20:15 +0100
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > The patch below does not apply to the 4.19-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@xxxxxxxxxxxxxxx>.
> >
> > Possible dependencies:
> >
> > 4313e5a61304 ("tracing: Free buffers when a used dynamic event is removed")
>
> Hmm, isn't the above the patch that failed to apply?
yes, tools are not the smartest at times :)
> > 5448d44c3855 ("tracing: Add unified dynamic event framework")
>
> And this is mentioned below.
>
> [..]
>
> > If any dynamic event that is being removed was enabled, then make sure the
> > buffers they were enabled in are now cleared.
> >
> > Link: https://lkml.kernel.org/r/20221123171434.545706e3@xxxxxxxxxxxxxxxxxx
> > Link: https://lore.kernel.org/all/20221110020319.1259291-1-zhengyejian1@xxxxxxxxxx/
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Depends-on: e18eb8783ec49 ("tracing: Add tracing_reset_all_online_cpus_unlocked() function")
>
> > Depends-on: 5448d44c38557 ("tracing: Add unified dynamic event framework")
>
> ^^^
Did you just make up a new field? We have a documented way to show
dependancies for stable patches, please let's not create a new one :(
> > Depends-on: 6212dd29683ee ("tracing/kprobes: Use dyn_event framework for kprobe events")
> > Depends-on: 065e63f951432 ("tracing: Only have rmmod clear buffers that its events were active in")
> > Depends-on: 575380da8b469 ("tracing: Only clear trace buffer on module unload if event was traced")
> > Fixes: 77b44d1b7c283 ("tracing/kprobes: Rename Kprobe-tracer to kprobe-event")
Adding the "unified framework" seems like way too much for a stable
patch, are you sure all of these are required and should be applied to
4.19.y?
thanks,
greg k-h
