Re: Patches needed in 3.2, 3.4, and 3.10 to fix mips problems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 13, 2014 at 03:27:52PM +0100, Ben Hutchings wrote:
> On Sat, 2014-09-13 at 00:47 -0700, Guenter Roeck wrote:
> > On 09/12/2014 05:49 PM, Greg Kroah-Hartman wrote:
> > > On Fri, Aug 15, 2014 at 09:06:06AM -0700, Guenter Roeck wrote:
> > >> Ben,
> > >> Greg,
> > >>
> > >> please apply the following patches to the respective -stable branches.
> > >>
> > >> I started seeing the problems fixed with those patches after updating
> > >> my qemu tests to also execute SMP builds. Patches apply cleanly to all
> > >> branches, and my tests pass with the patches applied.
> > >>
> > >> Thanks,
> > >> Guenter
> > >> ---------
> > >>
> > >> 3.2:
> > >>      6c37c9580409 MIPS: perf: Fix build error caused by unused counters_per_cpu_to_total()
> > >>      ff522058bd71 MIPS: Fix accessing to per-cpu data when flushing the cache
> > >>
> > >> 3.4:
> > >>      6c37c9580409 MIPS: perf: Fix build error caused by unused counters_per_cpu_to_total()
> > >>      ff522058bd71 MIPS: Fix accessing to per-cpu data when flushing the cache
> > >>
> > >> 3.10:
> > >>      ff522058bd71 MIPS: Fix accessing to per-cpu data when flushing the cache
> > >
> > > Applied to 3.10, thanks.
> > >
> > > greg k-h
> > >
> > >
> > 
> > Unrelated, but there is a new 3.10-stable-queue build failure.
> > 
> > Building powerpc:cell_defconfig ... failed
> > 
> > /opt/buildbot/slave/stable-queue-3.10/build/arch/powerpc/include/asm/pte-hash64-64k.h: In function '__real_pte':
> > /opt/buildbot/slave/stable-queue-3.10/build/arch/powerpc/include/asm/pte-hash64-64k.h:61:3: error: implicit declaration of function 'smp_rmb' [-Werror=implicit-function-declaration]
> >     smp_rmb();
> >     ^
> > cc1: some warnings being treated as errors
> > make[1]: *** [arch/powerpc/kernel/asm-offsets.s] Error 1
> > 
> > Ben had the same error in 3.2 if I remember correctly.
> 
> Yes, so I folded this into "powerpc/mm: Use read barrier when creating
> real_pte":
> 
> --- a/arch/powerpc/include/asm/pte-hash64-64k.h
> +++ b/arch/powerpc/include/asm/pte-hash64-64k.h
> @@ -40,6 +40,8 @@
>  
>  #ifndef __ASSEMBLY__
>  
> +#include <asm/system.h> /* for smp_rmb() */
> +
>  /*
>   * With 64K pages on hash table, we have a special PTE format that
>   * uses a second "half" of the page table to encode sub-page information
> --- END ---

Thanks, now added, hopefully that fixes the build issue.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]