On 2022/11/16 18:32, Pavel Machek wrote:
Hi!
From: Shang XiaoJing <shangxiaojing@xxxxxxxxxx>
[ Upstream commit 93d904a734a74c54d945a9884b4962977f1176cd ]
nfcmrvl_i2c_nci_send() will be called by nfcmrvl_nci_send(), and skb
should be freed in nfcmrvl_i2c_nci_send(). However, nfcmrvl_nci_send()
will only free skb when i2c_master_send() return >=0, which means skb
will memleak when i2c_master_send() failed. Free skb no matter whether
i2c_master_send() succeeds.
We still need to free the skb in the other error exits, right?
Hi,
I'll check and try to fix.
Thanks,
--
Shang XiaoJing