On Thu, Oct 27, 2022 at 08:41:45AM -0400, Mikulas Patocka wrote:
> commit d6ffe6067a54972564552ea45d320fb98db1ac5e upstream.
>
> Some architectures define their own arch_test_bit and they also need
> arch_test_bit_acquire, otherwise they won't compile. We also clean up
> the code by using the generic test_bit if that is equivalent to the
> arch-specific version.
>
> Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 8238b4579866 ("wait_on_bit: add an acquire memory barrier")
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>
> ---
> arch/alpha/include/asm/bitops.h | 7 +++++++
> arch/h8300/include/asm/bitops.h | 3 ++-
> arch/hexagon/include/asm/bitops.h | 15 +++++++++++++++
> arch/ia64/include/asm/bitops.h | 7 +++++++
> arch/m68k/include/asm/bitops.h | 6 ++++++
> arch/s390/include/asm/bitops.h | 7 +++++++
> arch/sh/include/asm/bitops-op32.h | 7 +++++++
> 7 files changed, 51 insertions(+), 1 deletion(-)
This is _very_ different from the upstream change that you are trying to
backport here.
Are you sure it is correct? You are adding real functions for these
arches, while the original backport was _REMOVING_ them and having the
arch code call the generic functions.
So why is this the same?
confused,
greg k-h
