3.2.63-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Axel Lin <axel.lin@xxxxxxxxxx> commit e981429557cbe10c780fab1c1a237cb832757652 upstream. Current code uses data_rate as array index in ads1015_read_adc() and uses pga as array index in ads1015_reg_to_mv, so we must make sure both data_rate and pga settings are in valid value range. Return -EINVAL if the setting is out-of-range. Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> --- drivers/hwmon/ads1015.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/hwmon/ads1015.c +++ b/drivers/hwmon/ads1015.c @@ -200,6 +200,7 @@ static int ads1015_get_channels_config_o dev_err(&client->dev, "invalid gain on %s\n", node->full_name); + return -EINVAL; } } @@ -210,6 +211,7 @@ static int ads1015_get_channels_config_o dev_err(&client->dev, "invalid data_rate on %s\n", node->full_name); + return -EINVAL; } } -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html