Re: [PATCH] uas: Add missing le16_to_cpu calls to asm1051 / asm1053 usb-id check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hans de Goede <hdegoede@xxxxxxxxxx> writes:

> --- a/drivers/usb/storage/uas-detect.h
> +++ b/drivers/usb/storage/uas-detect.h
> @@ -73,8 +73,8 @@ static int uas_use_uas_driver(struct usb_interface *intf,
>  	 * broken on the ASM1051, use the number of streams to differentiate.
>  	 * New ASM1053-s also support 32 streams, but have a different prod-id.
>  	 */
> -	if (udev->descriptor.idVendor == 0x174c &&
> -			udev->descriptor.idProduct == 0x55aa) {
> +	if (le16_to_cpu(udev->descriptor.idVendor) == 0x174c &&
> +			le16_to_cpu(udev->descriptor.idProduct) == 0x55aa) {
>  		if (udev->speed < USB_SPEED_SUPER) {
>  			/* No streams info, assume ASM1051 */
>  			flags |= US_FL_IGNORE_UAS;


Not that it matters much in this case, but I believe converting the
constants is preferred so that this can be resolved at build time
instead of runtime.

I.e.
	if (udev->descriptor.idVendor == cpu_to_le16(0x174c) &&
etc



Bjørn
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]