Re: [PATCH stable 3.12.y] usb: host: ohci-spear: fix ohci_dump parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 7 Sep 2014, Vincent Stehlé wrote:

> Commit 6a04d05acfb51355 ("USB: OHCI: fix bugs in debug routines") has removed
> the unused `verbose' argument of the debug function ohci_dump(); adapt
> ohci-spear accordingly.
> 
> This fixes the following compilation error:
> 
>   drivers/usb/host/ohci-spear.c: In function ‘ohci_spear_start’:
>   drivers/usb/host/ohci-spear.c:56:2: error: too many arguments to function ‘ohci_dump’
> 
> Signed-off-by: Vincent Stehlé <vincent.stehle@xxxxxxxxxxx>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Jiri Slaby <jslaby@xxxxxxx>
> ---
> 
> Hi,
> 
> This can be seen with Linux v3.12.28, arm allmodconfig.
> 
> And FWIW, it means `DEBUG' is defined in ohci-spear.c for arm allmodconfig.
> 
> Best regards,
> 
> V.
> 
>  drivers/usb/host/ohci-spear.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ohci-spear.c b/drivers/usb/host/ohci-spear.c
> index cc9dd9e..45f8773 100644
> --- a/drivers/usb/host/ohci-spear.c
> +++ b/drivers/usb/host/ohci-spear.c
> @@ -53,7 +53,7 @@ static int ohci_spear_start(struct usb_hcd *hcd)
>  	create_debug_files(ohci);
>  
>  #ifdef DEBUG
> -	ohci_dump(ohci, 1);
> +	ohci_dump(ohci);
>  #endif
>  	return 0;
>  }

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]