Hi!
> From: Ard Biesheuvel <ardb@xxxxxxxxxx>
>
> commit d80ca810f096ff66f451e7a3ed2f0cd9ef1ff519 upstream.
>
> Currently, the non-x86 stub code calls get_memory_map() redundantly,
> given that the data it returns is never used anywhere. So drop the
> call.
In mainline, map is not used after this point.
But in 5.10, map is passed to
status = efi_exit_boot_services(handle, &map, &priv, exit_boot_func);
few lines below. Can someone verify this reasoning still holds?
Thanks and best regards,
Pavel
> +++ b/drivers/firmware/efi/libstub/fdt.c
> @@ -281,14 +281,6 @@ efi_status_t allocate_new_fdt_and_exit_b
> goto fail;
> }
>
> - /*
> - * Now that we have done our final memory allocation (and free)
> - * we can get the memory map key needed for exit_boot_services().
> - */
> - status = efi_get_memory_map(&map);
> - if (status != EFI_SUCCESS)
> - goto fail_free_new_fdt;
> -
> status = update_fdt((void *)fdt_addr, fdt_size,
> (void *)*new_fdt_addr, MAX_FDT_SIZE, cmdline_ptr,
> initrd_addr, initrd_size);
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Attachment:
signature.asc
Description: PGP signature
