Re: Incorrect backport to 2.6.32-stable - NFSD regression.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(Adding Willy to the CC list, in case he misses this email.)

On Wed, Sep 03, 2014 at 11:28:43AM +1000, NeilBrown wrote:
> 
> 2.6.32.30 contains:
> 
> commit 63d059e73ff4574b79bd8aa252b5fc00b6326ddf
> Author: NeilBrown <neilb@xxxxxxx>
> Date:   Wed Feb 16 13:08:35 2011 +1100
> 
>     nfsd: correctly handle return value from nfsd_map_name_to_*
>     
>     commit 47c85291d3dd1a51501555000b90f8e281a0458e upstream.
>     
>     These functions return an nfs status, not a host_err.  So don't
>     try to convert  before returning.
>     
>     This is a regression introduced by
>     3c726023402a2f3b28f49b9d90ebf9e71151157d; I fixed up two of the callers,
>     but missed these two.
>     
>     Reported-by: Herbert Poetzl <herbert@xxxxxxxxxxxx>
>     Signed-off-by: NeilBrown <neilb@xxxxxxx>
>     Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> 
> 
> But it does *not* contain a backport of
> 3c726023402a2f3b28f49b9d90ebf9e71151157d.
> 
> So rather an fixing a regression, it introduces one.
> 
> This patch should be reverted.
> 
> See also https://bugzilla.novell.com/show_bug.cgi?id=893787
> 
> NeilBrown

Thanks a lot for reporting this here, Neil.  I'll make sure we revert
it from the Ubuntu 10.04 LTS kernel.

Cheers,
--
Luís
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]