Re: [PATCH] drm/i915: Fix EIO/wedged handling in gem fault handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 04, 2014 at 09:36:18AM +0200, Daniel Vetter wrote:
> In
> 
> commit 1f83fee08d625f8d0130f9fe5ef7b17c2e022f3c
> Author: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Date:   Thu Nov 15 17:17:22 2012 +0100
> 
>     drm/i915: clear up wedged transitions
> 
> I've accidentally inverted the EIO/wedged handling in the fault
> handler: We want to return the EIO as a SIGBUS only if it's not
> because of the gpu having died, to prevent userspace from unduly
> dying.
> 
> In my defence the comment right above is completely misleading, so fix
> both.
> 
> v2: Drop the WARN_ON, it's not actually a bug to e.g. receive an -EIO
> when swap-in fails.
> 
> v3: Don't remove too much ... oops.
> 
> Reported-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]