On Wed, 03 Sep 2014 19:50:26 -0400, Chris Mason wrote: > On 09/03/2014 07:36 PM, Holger Hoffstätte wrote: >> [snip] >> Should they also go into the next 3.14.x stable cycle? This rename >> deadlock sounds like a possible problem with rsync, which seems like a >> popular use case, and I guess nobody will complain about slightly >> better performance either. > > Right, the btrfs_flush_all_pending_stuffs function can just be deleted. https://github.com/hhoffstaette/kernel-patches/ blob/86d65551515e51aa892f2ca26be0c75545c22d37/3.14/btrfs-20140812-disable- strict-file-flushes-for-renames-and-truncates.patch It just built & it's running. I can still rename+truncate files without upsetting The Old Ones, so that seems good. > But, Liu Bo's patch isn't required on 3.14 (since the regression he > fixed came with 3.15). That's clear - wasn't talking about that. :) > And these changes are big enough that I like to test them a little here > before sending out. I did mark that patch as 3.15+, but really that > deadlock has been there forever. We only started seeing it with 3.15+ > because other waitqueue problems made it stand out. Interesting. I'll keep running with the two filemap_flush patches and see how it goes, but so far it looks good. thanks! Holger -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html