Re: [PATCH] drm/amdgpu/discovery: fix possible memory leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Luben Tuikov <luben.tuikov@xxxxxxx>

Regards,
Luben

On 2022-10-19 03:06, Yang Yingliang wrote:
> If kset_register() fails, the refcount of kobject is not 0,
> the name allocated in kobject_set_name(&kset.kobj, ...) is
> leaked. Fix this by calling kset_put(), so that it will be
> freed in callback function kobject_cleanup().
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: a6c40b178092 ("drm/amdgpu: Show IP discovery in sysfs")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> index 3993e6134914..638edcf70227 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -863,7 +863,7 @@ static int amdgpu_discovery_sysfs_ips(struct amdgpu_device *adev,
>  				res = kset_register(&ip_hw_id->hw_id_kset);
>  				if (res) {
>  					DRM_ERROR("Couldn't register ip_hw_id kset");
> -					kfree(ip_hw_id);
> +					kset_put(&ip_hw_id->hw_id_kset);
>  					return res;
>  				}
>  				if (hw_id_names[ii]) {
> @@ -954,7 +954,7 @@ static int amdgpu_discovery_sysfs_recurse(struct amdgpu_device *adev)
>  		res = kset_register(&ip_die_entry->ip_kset);
>  		if (res) {
>  			DRM_ERROR("Couldn't register ip_die_entry kset");
> -			kfree(ip_die_entry);
> +			kset_put(&ip_die_entry->ip_kset);
>  			return res;
>  		}
>  
> @@ -989,6 +989,7 @@ static int amdgpu_discovery_sysfs_init(struct amdgpu_device *adev)
>  	res = kset_register(&adev->ip_top->die_kset);
>  	if (res) {
>  		DRM_ERROR("Couldn't register die_kset");
> +		kset_put(&adev->ip_top->die_kset);
>  		goto Err;
>  	}
>  



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux