Hi! > > From: Nathan Huckleberry <nhuck@xxxxxxxxxx> > > > > [ Upstream commit 106c67ce46f3c82dd276e983668a91d6ed631173 ] > > > > The ndo_start_xmit field in net_device_ops is expected to be of type > > netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev). > > > > The mismatched return type breaks forward edge kCFI since the underlying > > function definition does not match the function hook definition. > > > > The return type of korina_send_packet should be changed from int to > > netdev_tx_t. > > Patches 4-6, 9-11: I see this is nice cleanup for mainline, but ... do > we have CFI in 4.9 tree? This mismatch does not and can not cause any > problems there, right? Quoting Greg on very similar patch: #kCFI showed up in 6.1, so this is not needed in any stable branches, #please drop it from all. #thanks, #greg k-h Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Attachment:
signature.asc
Description: PGP signature
