Re: [PATCH stable-5.4 1/1] io_uring/af_unix: defer registered files gc to io_uring release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 17, 2022 at 12:03:11AM +0100, Pavel Begunkov wrote:
> [ upstream commit 0091bfc81741b8d3aeb3b7ab8636f911b2de6e80 ]
> 
> Instead of putting io_uring's registered files in unix_gc() we want it
> to be done by io_uring itself. The trick here is to consider io_uring
> registered files for cycle detection but not actually putting them down.
> Because io_uring can't register other ring instances, this will remove
> all refs to the ring file triggering the ->release path and clean up
> with io_ring_ctx_free().
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 6b06314c47e1 ("io_uring: add file set registration")
> Reported-and-tested-by: David Bouman <dbouman03@xxxxxxxxx>
> Signed-off-by: Pavel Begunkov <asml.silence@xxxxxxxxx>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxx>
> [axboe: add kerneldoc comment to skb, fold in skb leak fix]
> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
> ---
>  fs/io_uring.c          |  1 +
>  include/linux/skbuff.h |  2 ++
>  net/unix/garbage.c     | 20 ++++++++++++++++++++
>  3 files changed, 23 insertions(+)

Now queued up, thanks.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux