Dominique Martinet wrote on Mon, Oct 17, 2022 at 10:39:10AM +0900: > diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c > index a2c4eab0b470..5ca61fa50efd 100644 > --- a/drivers/tty/serial/fsl_lpuart.c > +++ b/drivers/tty/serial/fsl_lpuart.c > @@ -2667,10 +2667,6 @@ static int lpuart_probe(struct platform_device *pdev) > if (ret) > goto failed_irq_request; > > - ret = uart_add_one_port(&lpuart_reg, &sport->port); > - if (ret) > - goto failed_attach_port; > - > ret = uart_get_rs485_mode(&sport->port); > if (ret) > goto failed_get_rs485; > @@ -2683,6 +2679,9 @@ static int lpuart_probe(struct platform_device *pdev) > dev_err(&pdev->dev, "driver doesn't support RTS delays\n"); > > sport->port.rs485_config(&sport->port, &sport->port.rs485); Ah, I've been quick on the review, sorry: this rs485_config() should probably be removed. (the similar uart_rs485_config() was removed in the upstream patch) I'll send a v2 after this has gotten another review or when prompted, sorry for the trouble. > + ret = uart_add_one_port(&lpuart_reg, &sport->port); > + if (ret) > + goto failed_attach_port; > > return 0; >
