Re: Patch "usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1" has been added to the 3.16-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch is okay for the stable branches if the follow-up patch for
CONFIG_PM_RUNTIME is also applied.
https://lkml.org/lkml/2014/8/27/645

On Wed, Sep 3, 2014 at 4:58 PM,  <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> This is a note to let you know that I've just added the patch titled
>
>     usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1
>
> to the 3.16-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
>      usb-hub-prevent-hub-autosuspend-if-usbcore.autosuspend-is-1.patch
> and it can be found in the queue-3.16 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.
>
>
> From bdd405d2a5287bdb9b04670ea255e1f122138e66 Mon Sep 17 00:00:00 2001
> From: Roger Quadros <rogerq@xxxxxx>
> Date: Mon, 4 Aug 2014 12:44:46 +0300
> Subject: usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1
>
> From: Roger Quadros <rogerq@xxxxxx>
>
> commit bdd405d2a5287bdb9b04670ea255e1f122138e66 upstream.
>
> If user specifies that USB autosuspend must be disabled by module
> parameter "usbcore.autosuspend=-1" then we must prevent
> autosuspend of USB hub devices as well.
>
> commit 596d789a211d introduced in v3.8 changed the original behaivour
> and stopped respecting the usbcore.autosuspend parameter for hubs.
>
> Fixes: 596d789a211d "USB: set hub's default autosuspend delay as 0"
>
> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> Tested-by: Michael Welling <mwelling@xxxxxxxxxxx>
> Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> ---
>  drivers/usb/core/hub.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -1728,8 +1728,12 @@ static int hub_probe(struct usb_interfac
>          * - Change autosuspend delay of hub can avoid unnecessary auto
>          *   suspend timer for hub, also may decrease power consumption
>          *   of USB bus.
> +        *
> +        * - If user has indicated to prevent autosuspend by passing
> +        *   usbcore.autosuspend = -1 then keep autosuspend disabled.
>          */
> -       pm_runtime_set_autosuspend_delay(&hdev->dev, 0);
> +       if (hdev->dev.power.autosuspend_delay >= 0)
> +               pm_runtime_set_autosuspend_delay(&hdev->dev, 0);
>
>         /*
>          * Hubs have proper suspend/resume support, except for root hubs
>
>
> Patches currently in stable-queue which might be from rogerq@xxxxxx are
>
> queue-3.16/usb-hub-prevent-hub-autosuspend-if-usbcore.autosuspend-is-1.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]