On Fri, Oct 14, 2022 at 01:04:10PM +0200, Johannes Berg wrote: > On Fri, 2022-10-14 at 06:56 -0300, Thadeu Lima de Souza Cascardo wrote: > > On Fri, Oct 14, 2022 at 09:11:45AM +0200, Greg KH wrote: > > > On Thu, Oct 13, 2022 at 08:15:56PM +0200, Felix Fietkau wrote: > > > > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > > > > > > > commit a5b983c6073140b624f64e79fea6d33c3e4315a0 upstream. > > > > > > > > We currently pass the entire elements to the rx_bcn_presp() > > > > method, but only need mesh_config. Additionally, we use the > > > > length of the elements to calculate back the entire frame's > > > > length, but that's confusing - just pass the length of the > > > > frame instead. > > > > > > > > Link: https://lore.kernel.org/r/20210920154009.a18ed3d2da6c.I1824b773a0fbae4453e1433c184678ca14e8df45@changeid > > > > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> > > > > --- > > > > net/mac80211/ieee80211_i.h | 7 +++---- > > > > net/mac80211/mesh.c | 4 ++-- > > > > net/mac80211/mesh_sync.c | 26 ++++++++++++-------------- > > > > 3 files changed, 17 insertions(+), 20 deletions(-) > > > > > > Many thanks for this series. Will this also work in 5.4.y and 5.10.y? > > > > > > > Not sure about 5.10, but that won't work as is on 5.4. We are considering some > > other approach for 5.4, but not sure yet. But simply taking dozens of clean > > cherry picks did not strike as a good option to me. Taking lots of clean cherrypicks _is_ normally the best way, I have no objection to that at all as it keeps things in sync properly. Doing out-of-tree changes is the hard way and we almost always get that wrong. > I'm thinking of just disabling multi-BSSID, it's not really used anyway > as far as I can tell. That's fine with me too if it's an easy change and no one complains or notices :) thanks, greg k-h
