On Wed, Sep 03, 2014 at 02:36:11PM -0700, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > This is a note to let you know that I've just added the patch titled > > ext4: propagate errors up to ext4_find_entry()'s callers I hate to do this again, but could you hold up this patch until the next stable release? The following hasn't been pushed out to Linus yet, but it fixes a bug which was overlooked in the review. (Ironically, I had found another instance of the same mistake elsewhere in an earlier version of this commit patch, and asked Dan Carpenter to code up a smatch patch to scan for this mistake, since it's so easy to make/miss --- and then promptly proved this by missing the other two instances of the same mistake in fs/namei.c in that patch. Sigh...) http://git.kernel.org/cgit/linux/kernel/git/tytso/ext4.git/commit/?h=for_linus_urgent ext4: avoid trying to kfree an ERR_PTR pointer Thanks to Dan Carpenter for extending smatch to find bugs like this. (This was found using a development version of smatch.) Fixes: 36de928641ee48b2078d3fe9514242aaa2f92013 Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx Signed-off-by: Theodore Ts'o <tytso@xxxxxxx> Cc: stable@xxxxxxxxxxxxxxx The incidence rate of the bug fixed by 36de928641e is pretty rare, especially in the upstream kernel specially in the upstream kernel, so it shouldn't be too bad to just hold back this fix for a week or so. Thanks, and apologies for the inconvenience. - Ted -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html