On Wed, Oct 12, 2022 at 08:18:21PM -0400, Sasha Levin wrote: > From: Xiaoke Wang <xkernel.wang@xxxxxxxxxxx> > > [ Upstream commit 06bfdb6d889f57fe9ce7bd139ce278b68f3a59de ] > > In rtw_init_cmd_priv(), if `pcmdpriv->rsp_allocated_buf` is allocated > in failure, then `pcmdpriv->cmd_allocated_buf` will not be properly > released. Besides, considering there are only two error paths and the > first one can directly return, we do not need to implicitly jump to the > `exit` tag to execute the error handling code. > > So this patch added `kfree(pcmdpriv->cmd_allocated_buf);` on the error > path to release the resource and simplified the return logic of > rtw_init_cmd_priv(). As there is no proper device to test with, no > runtime testing was performed. > > Tested-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx> # Edimax N150 > Signed-off-by: Xiaoke Wang <xkernel.wang@xxxxxxxxxxx> > Link: https://lore.kernel.org/r/tencent_1B6AAE10471D4556788892F8FF3E4812F306@xxxxxx > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > --- > drivers/staging/r8188eu/core/rtw_cmd.c | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) This isn't needed in stable trees, please drop from all branches. greg k-h
