On Wed, 2022-10-12 at 20:17 -0400, Sasha Levin wrote:
> From: Michael Straube <straube.linux@xxxxxxxxx>
>
> [ Upstream commit 9a4d0d1c21b974454926c3b832b4728679d818eb ]
>
> Drivers should not spam the kernel log if they work properly. Convert
> the functions Hal_EfuseParseIDCode88E() and _netdev_open() to use
> netdev_dbg() instead of pr_info() so that developers can still enable
> it if they want to see this information.
Why should this be backported?
> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
[]
> @@ -676,6 +676,7 @@ Hal_EfuseParseIDCode88E(
> )
> {
> struct eeprom_priv *pEEPROM = &padapter->eeprompriv;
> + struct net_device *netdev = padapter->pnetdev;
> u16 EEPROMId;
>
> /* Check 0x8129 again for making sure autoload status!! */
> @@ -687,7 +688,7 @@ Hal_EfuseParseIDCode88E(
> pEEPROM->bautoload_fail_flag = false;
> }
>
> - pr_info("EEPROM ID = 0x%04x\n", EEPROMId);
> + netdev_dbg(netdev, "EEPROM ID = 0x%04x\n", EEPROMId);
> }
>
> static void Hal_ReadPowerValueFromPROM_8188E(struct txpowerinfo24g *pwrInfo24G, u8 *PROMContent, bool AutoLoadFail)
> diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c
[]
> @@ -636,7 +636,7 @@ int _netdev_open(struct net_device *pnetdev)
> if (status == _FAIL)
> goto netdev_open_error;
>
> - pr_info("MAC Address = %pM\n", pnetdev->dev_addr);
> + netdev_dbg(pnetdev, "MAC Address = %pM\n", pnetdev->dev_addr);
>
> status = rtw_start_drv_threads(padapter);
> if (status == _FAIL) {
