On Mon, Sep 26, 2022 at 04:16:02PM +0200, Ard Biesheuvel wrote: > On Mon, 26 Sept 2022 at 13:08, Pavel Machek <pavel@xxxxxxx> wrote: > > > > Hi! > > > > > These structs look like the ideal randomization candidates to the > > > randstruct plugin (as they only carry function pointers), but of course, > > > these protocols are contracts between the firmware that exposes them, > > > and the EFI applications (including our stubbed kernel) that invoke > > > them. This means that struct randomization for EFI protocols is not a > > > great idea, and given that the stub shares very little data with the > > > core kernel that is represented as a randomizable struct, we're better > > > off just disabling it completely here. > > > > > Cc: <stable@xxxxxxxxxxxxxxx> # v4.14+ > > > > AFAICT RANDSTRUCT_CFLAGS is not available in v4.19, so we should not > > take this patch. > > > > Ugh, as it turns out, this macro doesn't exist before v5.19 so it > should not be backported beyond that version at all. > > Greg, can you please drop this patch from all the -stable trees except > v5.19? Thanks, and apologies for creating confusion. Now dropped from the 4.14, 4.19, and 5.4 queues, it is already in the 5.10 release. thanks, greg k-h
