On 9/26/22 17:28, Pavel Machek wrote: > On Mon 2022-09-26 12:11:35, Greg Kroah-Hartman wrote: >> From: Xiang wangx <wangxiang@xxxxxxxxxx> >> >> [ Upstream commit fc378794a2f7a19cf26010dc33b89ba608d4c70f ] >> >> Delete the redundant word 'its'. > > This does not belong in stable. > Without seeing the upstream commit, the patch subject is misleading: the patch doesn't fix any syntax errors as one might get from the compiler. Also, what I find irritating is that I have never seen reply from @cdjrlc.com people to review comments pointing flaws of their patch. I guess they don't have any other jobs here in LKML other than just throwing one-line redundant word stripping patches. The similar cause is why Jani Nikula [1] and Greg NAKed cgel.zte patches (ignoring reviews and "atypical" corporate email structure [2]) Hence NAK (agree with your verdict). However, should the upstream commit be reverted? [1]: https://lore.kernel.org/lkml/878rn1dd8l.fsf@xxxxxxxxx/ [2]: https://lore.kernel.org/lkml/Yylv5hbSBejJ58nt@xxxxxxxxx/ -- An old man doll... just what I always wanted! - Clara
