Hi!
> From: Yihao Han <hanyihao@xxxxxxxx>
>
> [ Upstream commit 5491424d17bdeb7b7852a59367858251783f8398 ]
>
> clk_put() already checks the clk ptr using !clk and IS_ERR()
> so there is no need to check it again before calling it.
This does not really fix any bug, so I'd preffer not to have it in
stable.
Best regards,
Pavel
> +++ b/drivers/video/fbdev/simplefb.c
> @@ -231,8 +231,7 @@ static int simplefb_clocks_init(struct simplefb_par *par,
> if (IS_ERR(clock)) {
> if (PTR_ERR(clock) == -EPROBE_DEFER) {
> while (--i >= 0) {
> - if (par->clks[i])
> - clk_put(par->clks[i]);
> + clk_put(par->clks[i]);
> }
> kfree(par->clks);
> return -EPROBE_DEFER;
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Attachment:
signature.asc
Description: Digital signature
