> -----Original Message----- > From: Kalle Valo <kvalo@xxxxxxxxxx> > Sent: Monday, September 26, 2022 1:27 PM > To: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Cc: Larry.Finger@xxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; Bernie Huang <phhuang@xxxxxxxxxxx>; > linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v6.0-rc] wifi: rtw89: free unused skb to prevent memory leak > > Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes: > > > From: Po-Hao Huang <phhuang@xxxxxxxxxxx> > > > > This avoid potential memory leak under power saving mode. > > > > Fixes: fc5f311fce74 ("rtw89: don't flush hci queues and send h2c if power is off") > > Cc: stable@xxxxxxxxxxxxxxx > > Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > > Signed-off-by: Po-Hao Huang <phhuang@xxxxxxxxxxx> > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxx> > > Link: https://lore.kernel.org/r/20220916033811.13862-6-pkshih@xxxxxxxxxxx > > --- > > Hi Kalle, > > > > We want this patch go to v6.0-rc, because it can fix memleak caused by another > > patch. For users, this driver eats memory and could lead out-of-memory > > finally. > > > > This patch has been merged into wireless-next, but I forget to add "Fixes" > > tag and Cc stable, so I add them to commit messages. If this works, I will > > prepare another patch for v5.19. > > -rc7 is already released, so we are quite late in the cycle, and I'm not > planning to submit another pull request for v6.0 unless something really > major happens. So I think it's better that you wait for the -next commit > to reach Linus' tree (should happen in next two weeks or so) and then > submit a patch to stable releases. > Got it. I will do it weeks later. Thanks. Ping-Ke