This is a note to let you know that I've just added the patch titled
hwmon: (sis5595) Prevent overflow problem when writing large limits
to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
hwmon-sis5595-prevent-overflow-problem-when-writing-large-limits.patch
and it can be found in the queue-3.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From cc336546ddca8c22de83720632431c16a5f9fe9a Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@xxxxxxxxxx>
Date: Thu, 31 Jul 2014 22:27:04 +0800
Subject: hwmon: (sis5595) Prevent overflow problem when writing large limits
From: Axel Lin <axel.lin@xxxxxxxxxx>
commit cc336546ddca8c22de83720632431c16a5f9fe9a upstream.
On platforms with sizeof(int) < sizeof(long), writing a temperature
limit larger than MAXINT will result in unpredictable limit values
written to the chip. Avoid auto-conversion from long to int to fix
the problem.
Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/hwmon/sis5595.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/hwmon/sis5595.c
+++ b/drivers/hwmon/sis5595.c
@@ -159,7 +159,7 @@ static inline int TEMP_FROM_REG(s8 val)
{
return val * 830 + 52120;
}
-static inline s8 TEMP_TO_REG(int val)
+static inline s8 TEMP_TO_REG(long val)
{
int nval = clamp_val(val, -54120, 157530) ;
return nval < 0 ? (nval - 5212 - 415) / 830 : (nval - 5212 + 415) / 830;
Patches currently in stable-queue which might be from axel.lin@xxxxxxxxxx are
queue-3.10/hwmon-sis5595-prevent-overflow-problem-when-writing-large-limits.patch
queue-3.10/hwmon-ads1015-fix-off-by-one-for-valid-channel-index-checking.patch
queue-3.10/hwmon-lm78-fix-overflow-problems-seen-when-writing-large-temperature-limits.patch
queue-3.10/hwmon-gpio-fan-prevent-overflow-problem-when-writing-large-limits.patch
queue-3.10/hwmon-ads1015-fix-out-of-bounds-array-access.patch
queue-3.10/hwmon-dme1737-prevent-overflow-problem-when-writing-large-limits.patch
queue-3.10/hwmon-lm85-fix-various-errors-on-attribute-writes.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html