On Thu, Sep 22, 2022 at 04:28:25PM -0500, Alex Elder wrote: > On 9/22/22 4:18 PM, Douglas Anderson wrote: > > From: Mike Tipton <mdtipton@xxxxxxxxxxxxxx> > > > > commit b95b668eaaa2574e8ee72f143c52075e9955177e upstream. > > > > We're only adding BCMs to the commit list in aggregate(), but there are > > cases where pre_aggregate() is called without subsequently calling > > aggregate(). In particular, in icc_sync_state() when a node with initial > > BW has zero requests. Since BCMs aren't added to the commit list in > > these cases, we don't actually send the zero BW request to HW. So the > > resources remain on unnecessarily. > > > > Add BCMs to the commit list in pre_aggregate() instead, which is always > > called even when there are no requests. > > > > Signed-off-by: Mike Tipton <mdtipton@xxxxxxxxxxxxxx> > > [georgi: remove icc_sync_state for platforms with incomplete support] > > Link: https://lore.kernel.org/r/20211125174751.25317-1-djakov@xxxxxxxxxx > > Signed-off-by: Georgi Djakov <djakov@xxxxxxxxxx> > > [dianders: dropped sm8350.c which isn't present in 5.10] > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > Whoops, sorry about that. > > Acked-by: Alex Elder <elder@xxxxxxxxxx> Now queued up, thanks. greg k-h
