On Thu, 22 Sept 2022 at 13:04, Sudeep Holla <sudeep.holla@xxxxxxx> wrote: > > On Wed, Sep 21, 2022 at 08:46:21PM +0200, Ulf Hansson wrote: > > On Wed, 21 Sept 2022 at 17:56, Sudeep Holla <sudeep.holla@xxxxxxx> wrote: > > > > > > Hi Dien, Gaku, > > > > > > On Mon, Sep 19, 2022 at 02:20:33PM +0200, Ulf Hansson wrote: > > > > This reverts commit a3b884cef873 ("firmware: arm_scmi: Add clock management > > > > to the SCMI power domain"). > > > > > > > > Using the GENPD_FLAG_PM_CLK tells genpd to gate/ungate the consumer > > > > device's clock(s) during runtime suspend/resume through the PM clock API. > > > > More precisely, in genpd_runtime_resume() the clock(s) for the consumer > > > > device would become ungated prior to the driver-level ->runtime_resume() > > > > callbacks gets invoked. > > > > > > > > This behaviour isn't a good fit for all platforms/drivers. For example, a > > > > driver may need to make some preparations of its device in its > > > > ->runtime_resume() callback, like calling clk_set_rate() before the > > > > clock(s) should be ungated. In these cases, it's easier to let the clock(s) > > > > to be managed solely by the driver, rather than at the PM domain level. > > > > > > > > For these reasons, let's drop the use GENPD_FLAG_PM_CLK for the SCMI PM > > > > domain, as to enable it to be more easily adopted across ARM platforms. > > > > > > > > Fixes: a3b884cef873 ("firmware: arm_scmi: Add clock management to the SCMI power domain") > > > > Cc: Nicolas Pitre <npitre@xxxxxxxxxxxx> > > > > Cc: stable@xxxxxxxxxxxxxxx > > > > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > > > > --- > > > > > > > > To get some more background to $subject patch, please have a look at the > > > > lore-link below. > > > > > > > > https://lore.kernel.org/all/DU0PR04MB94173B45A2CFEE3BF1BD313A88409@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > > > > > > > > > If you have any objections, this is your last chance to speak up before > > > the original change gets reverted in the mainline with this patch. > > > > > > Hi Ulf, > > > > > > I don't have any other SCMI changes for v6.0 fixes or v6.1 > > > I am fine if you are happy to take this via your tree or I can send it > > > to SoC team. Let me know. I will give final one or 2 days for Renesas > > > to get back if they really care much. > > > > I have a slew of fixes for mmc that I intend to send next week, I can > > funnel them through that pull request. > > > > Assuming, Renesas folkz are okay, I consider that as an ack from you, right? > > > > Yes for official reasons, here is the formal :) > > Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx> > Thanks! > in case you manage to get this in via your tree. I have now queued up the patch through git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git fixes Let's see how it goes when it gets tested in linux-next. > > -- > Regards, > Sudeep Kind regards Uffe