Hazem started separate e-mail threads on this issue (separated by
about an hour), and I replied to the earlier one here:
https://lore.kernel.org/all/Yypx6VQRbl3bFP2v@xxxxxxx/
TL;DR:
1) The patch landed in 5.6, and improved performance for some
workloads, and also fixed a potential security problem (exposure of
stale data caused by a race).
2) If you are using a storage device >= 128GB, and a version of
e2fsprogs v1.43.2 (released six years ago), the journal size will be
1GB, which Hazem reported resolved the problem.
3) I disagree that we should revert this commit, as it only changes a
default. If you prefer the older behavior, you can change it with a
mount option.
- Ted
