On Tue, Sep 13, 2022 at 12:27 AM Eddie James <eajames@xxxxxxxxxxxxx> wrote: > > The DPS310 chip has been observed to get "stuck" such that pressure > and temperature measurements are never indicated as "ready" in the > MEAS_CFG register. The only solution is to reset the device and try > again. In order to avoid continual failures, use a boolean flag to > only try the reset after timeout once if errors persist. Include a > patch to move the startup procedure into a function. Good enough, although having a couple of nit-picks. Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Changes since v6: > - Use helper instead of the lengthy regmap_read_poll_timeout twice > - Just return dps310_startup in dps310_reset_reinit > > Changes since v5: > - Completely rework the second patch to reset and reinit in any > timeout condition, if there haven't been previous timeouts that > failed to recover the chip. > > Changes since v4: > - Just check for rc rather than rc < 0 in some cases > - Split declaration and init of rc > > Changes since v3: > - Don't check regmap* return codes for < 0 > - Fix comment spelling > > Changes since v2: > - Add some comments > - Fix the clunky control flow > > Changes since v1: > - Separate into two patches > - Rename 'dps310_verify_meas_cfg' to 'dps310_check_reset_meas_cfg' > > Eddie James (2): > iio: pressure: dps310: Refactor startup procedure > iio: pressure: dps310: Reset chip after timeout > > drivers/iio/pressure/dps310.c | 266 +++++++++++++++++++++------------- > 1 file changed, 167 insertions(+), 99 deletions(-) > > -- > 2.31.1 > -- With Best Regards, Andy Shevchenko
