On Tue, Sep 13, 2022 at 04:19:17PM +0200, Marc Kleine-Budde wrote: > Hello Greg, > > On 13.09.2022 16:03:49, Greg Kroah-Hartman wrote: > > From: Csókás Bence <csokas.bence@xxxxxxxxx> > > > > [ Upstream commit b353b241f1eb9b6265358ffbe2632fdcb563354f ] > > > > Mutexes cannot be taken in a non-preemptible context, > > causing a panic in `fec_ptp_save_state()`. Replacing > > `ptp_clk_mutex` by `tmreg_lock` fixes this. > > > > Fixes: 6a4d7234ae9a ("net: fec: ptp: avoid register access when ipg clock is disabled") > > Fixes: f79959220fa5 ("fec: Restart PPS after link state change") > > Reported-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > > Link: https://lore.kernel.org/all/20220827160922.642zlcd5foopozru@xxxxxxxxxxxxxx/ > > Signed-off-by: Csókás Bence <csokas.bence@xxxxxxxxx> > > Tested-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> # Toradex Apalis iMX6 > > Link: https://lore.kernel.org/r/20220901140402.64804-1-csokas.bence@xxxxxxxxx > > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> > > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > > there's a revert pending for this patch: > > | https://lore.kernel.org/all/20220912070143.98153-1-francesco.dolcini@xxxxxxxxxxx > > ...as it causes troubles in 6.0-rc4: > > | https://lore.kernel.org/all/20220907143915.5w65kainpykfobte@xxxxxxxxxxxxxx/ > | https://lore.kernel.org/all/CAHk-=wj1obPoTu1AHj9Bd_BGYjdjDyPP+vT5WMj8eheb3A9WHw@xxxxxxxxxxxxxx/ > > please drop this patch. Now dropped from all 3 queues, thanks. greg k-h