Re: [PATCH v3 2/2] net: dp83822: disable rx error interrupt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: "Greg KH" <gregkh@xxxxxxxxxxxxxxxxxxx>
> To: "Enguerrand de Ribaucourt" <enguerrand.de-ribaucourt@xxxxxxxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx, "Andrew Lunn" <andrew@xxxxxxx>, "Jakub Kicinski" <kuba@xxxxxxxxxx>
> Sent: Thursday, September 8, 2022 7:09:02 PM
> Subject: Re: [PATCH v3 2/2] net: dp83822: disable rx error interrupt

> On Wed, Sep 07, 2022 at 12:45:59PM +0200, Enguerrand de Ribaucourt wrote:
> > Some RX errors, notably when disconnecting the cable, increase the RCSR
> > register. Once half full (0x7fff), an interrupt flood is generated. I
> > measured ~3k/s interrupts even after the RX errors transfer was
> > stopped.

> > Since we don't read and clear the RCSR register, we should disable this
> > interrupt.

> > Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
>> Signed-off-by: Enguerrand de Ribaucourt
> > <enguerrand.de-ribaucourt@xxxxxxxxxxxxxxxxxxxx>
> > Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> > [backport of 5.10 commit 0e597e2affb90d6ea48df6890d882924acf71e19]
> > ---
> > drivers/net/phy/dp83822.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)

> Does not apply to 5.4.y or 4.19.y :(

I could apply the patch with no problems on those versions. I also could cherry-pick
the commit on the branch queue/5.4 from stable/linux-stable-rc.git without conflicts.

I can't reproduce the issue you seem to be facing when applying those patches. Would you
mind helping me finding what's wrong with the patch on those branches?

Thanks,

Enguerrand de Ribaucourt



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux