On Wed, Aug 24, 2022 at 03:43:26PM +0100, Jean-Philippe Brucker wrote: > Rajesh reports [1] that the test_align BPF selftest is broken in > 5.4.210. Three patches were added since 5.4.209: > > (A) 7c1134c7da99 ("bpf: Verifer, adjust_scalar_min_max_vals to always call update_reg_bounds()") > (B) 6a9b3f0f3bad ("selftests/bpf: Fix test_align verifier log patterns") > (C) 6098562ed9df ("selftests/bpf: Fix "dubious pointer arithmetic" test") > > (A) fixes an issue in the BPF verifier, which changes the verifier trace > output. (B) fixes those trace changes in the selftests. > > Unfortunately (B) also address changes to the verifier output from other > patches that weren't backported to v5.4, so the test now fails. > (C) also addresses a different verifier change that is not in v5.4. > > Therefore revert (C), and partially revert (B). > > [1] https://lore.kernel.org/all/CAPXMrf-C5XEUfOJd3GCtgtHOkc8DxDGbLxE5=GFmr+Py0zKxJA@xxxxxxxxxxxxxx/ > > Jean-Philippe Brucker (2): > Revert "selftests/bpf: Fix "dubious pointer arithmetic" test" > Revert "selftests/bpf: Fix test_align verifier log patterns" > > tools/testing/selftests/bpf/test_align.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > -- > 2.37.1 > Now queued up, thanks. greg k-h