On Tue, Aug 16, 2022 at 01:26:53PM +0300, Ovidiu Panait wrote:
> Cherry-pick selftest changes from upstream commit 2fa7d94afc1a ("bpf: Fix the
> off-by-two error in range markings") to fix the following verifier selftest
> failures:
> # root@intel-x86-64:~# ./test_verifier
> ...
> #495/p XDP pkt read, pkt_end > pkt_data', bad access 1 FAIL
> #498/p XDP pkt read, pkt_data' < pkt_end, bad access 1 FAIL
> #504/p XDP pkt read, pkt_data' >= pkt_end, bad access 1 FAIL
> #513/p XDP pkt read, pkt_end <= pkt_data', bad access 1 FAIL
> #519/p XDP pkt read, pkt_data > pkt_meta', bad access 1 FAIL
> #522/p XDP pkt read, pkt_meta' < pkt_data, bad access 1 FAIL
> #528/p XDP pkt read, pkt_meta' >= pkt_data, bad access 1 FAIL
> #537/p XDP pkt read, pkt_data <= pkt_meta', bad access 1 FAIL
> Summary: 924 PASSED, 0 SKIPPED, 8 FAILED
>
> Fixes: c315bd962528 ("bpf: Fix the off-by-two error in range markings")
> Signed-off-by: Ovidiu Panait <ovidiu.panait@xxxxxxxxxxxxx>
> ---
> tools/testing/selftests/bpf/test_verifier.c | 32 ++++++++++-----------
> 1 file changed, 16 insertions(+), 16 deletions(-)
You lost the authorship information of the original commit, as well as
all of the people on it and the needed information. And you did not cc:
anyone involved in that work at all :(
Just backport that patch again with the correct tests added, and skip
the non-test portion.
thanks,
greg k-h
