On Wed, 17 Aug 2022, Jani Nikula <jani.nikula@xxxxxxxxx> wrote: > On Wed, 17 Aug 2022, "Lisovskiy, Stanislav" <stanislav.lisovskiy@xxxxxxxxx> wrote: >> On Tue, Aug 16, 2022 at 06:37:20PM +0300, Jani Nikula wrote: >>> Avoid using ports that aren't initialized in case the VBT backlight or >>> CABC ports have invalid values. This fixes a NULL pointer dereference of >>> intel_dsi->dsi_hosts[port] in such cases. >>> >>> Cc: stable@xxxxxxxxxxxxxxx >>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> >> >> Would be interesting to figure out which one of those actually fixed the >> https://gitlab.freedesktop.org/drm/intel/-/issues/6476 issue, this one >> or next one. > > I asked to test with patch 1 alone first, and it lets them boot without > the oops. And it produces the warn added here. But this just filters > port C out of bl_ports, and doesn't fix the root cause. Patch 2 should > fix the root cause, get rid of the warn and give them functioning > backlight. I hope. There was no test results with patches 2&3. :) > >> Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@xxxxxxxxx> > > Thanks for the review! Also, pushed the series to drm-intel-next yesterday. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
