Re: [PATCH stable 5.4] Revert "tcp: change pingpong threshold to 3"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Mon, 15 Aug 2022 18:45:12 -0700
> On Mon, 15 Aug 2022 20:51:29 +0000 Kuniyuki Iwashima wrote:
> > From: Wei Wang <weiwan@xxxxxxxxxx>
> >
> > commit 4d8f24eeedc58d5f87b650ddda73c16e8ba56559 upstream.
> >
> > This reverts commit 4a41f453bedfd5e9cd040bad509d9da49feb3e2c.
> >
> > This to-be-reverted commit was meant to apply a stricter rule for the
> > stack to enter pingpong mode. However, the condition used to check for
> > interactive session "before(tp->lsndtime, icsk->icsk_ack.lrcvtime)" is
> > jiffy based and might be too coarse, which delays the stack entering
> > pingpong mode.
> > We revert this patch so that we no longer use the above condition to
> > determine interactive session, and also reduce pingpong threshold to 1.
> >
> > Fixes: 4a41f453bedf ("tcp: change pingpong threshold to 3")
> > Reported-by: LemmyHuang <hlm3280@xxxxxxx>
> > Suggested-by: Neal Cardwell <ncardwell@xxxxxxxxxx>
> > Signed-off-by: Wei Wang <weiwan@xxxxxxxxxx>
> > Acked-by: Neal Cardwell <ncardwell@xxxxxxxxxx>
> > Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> > Link: https://lore.kernel.org/r/20220721204404.388396-1-weiwan@xxxxxxxxxx
> > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> 
> Should we wait for the resolution in the original thread first?
> 
> https://lore.kernel.org/all/ca408271-8730-eb2b-f12e-3f66df2e643a@xxxxxxxxxx/

Oh, I missed that thread being active.
I'll keep eyes on it.
Thank you!





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux