On 08.08.22 15:28, Greg KH wrote: > But, we only take patches that actually do something. This one doesn't > do anything at all, and has no measurable performance or bugfix that I > can determine at all. Isn't "doing less" also worth the patch? I mean this patch removes a superflous pointer of the superblock struct making the kernel use less memory. It also saves a code line and operation during init and removes the (somewhat hidden in syntax) superflous indirect access (and hence memory read) of a pointer already available (likely even in a register) during get/set_mnt_opts. Of course the effect here is small but I think cleanups are always good to avoid a "death by a thousand cuts" scenario, i.e. that even small things help. But of course you may disagree, just wanted to provide my reasoning especially as you wrote earlier that deleting code is always good and I thought this patch fits that. Thanks, Alex
