Re: [PATCH v2 net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 05 Aug 2022 17:27:33 -0300 Jose Alonso wrote:
> To: David S. Miller <davem@xxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: netdev <netdev@xxxxxxxxxxxxxxx>, stable <stable@xxxxxxxxxxxxxxx>, Ronald Wahl <ronald.wahl@xxxxxxxxxxx>
> 
>     [PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
>     The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware
>     versions that have no issues.

But you tested with 1790 previously so isn't the misbehaviour on that
device going to come back if we remove the flag again?

>     The FLAG_SEND_ZLP is not safe to use in this context.
>     See:
>     https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378
>     
>     Reported-by: Ronald Wahl <ronald.wahl@xxxxxxxxxxx>
>     Link: https://bugzilla.kernel.org/show_bug.cgi?id=216327
>     Link: https://bugs.archlinux.org/task/75491
>     
>     Fixes: 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP")
>     Signed-off-by: Jose Alonso <joalonsof@xxxxxxxxx>

The commit message looks unnecessarily indented, could you try with git
format-patch / git send-email?



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux