在 2022/8/4 20:09, Greg KH 写道: > On Thu, Aug 04, 2022 at 12:01:57PM +0000, chenjun (AM) wrote: >> 在 2022/8/4 19:50, Greg KH 写道: >>> On Thu, Aug 04, 2022 at 11:15:38AM +0000, Chen Jun wrote: >>>> From: Helge Deller <deller@xxxxxx> >>>> >>>> commit e64242caef18b4a5840b0e7a9bff37abd4f4f933 upstream >>>> >>>> We need to prevent that users configure a screen size which is smaller than the >>>> currently selected font size. Otherwise rendering chars on the screen will >>>> access memory outside the graphics memory region. >>>> >>>> This patch adds a new function fbcon_modechange_possible() which >>>> implements this check and which later may be extended with other checks >>>> if necessary. The new function is called from the FBIOPUT_VSCREENINFO >>>> ioctl handler in fbmem.c, which will return -EINVAL if userspace asked >>>> for a too small screen size. >>>> >>>> Signed-off-by: Helge Deller <deller@xxxxxx> >>>> Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> >>>> Link: https://lore.kernel.org/all/20220706150253.2186-1-deller@xxxxxx/ >>>> [sudip: adjust context] >>> >>> Who is "sudip" here? >> >> Em..I misunderstood the meaning "sudip". I just mean I made some >> contextual adjustments. > > Then please use your name here when you resend them > >>> And the Link: line wasn't in the original commit, where did that come >>> from? >>> >> >> The mainline commit appears to be from this link. Should I remove the link? > > It is odd to see fields that are not in the upstream commit be added > without any explaination (i.e. it's not an obvious signed-off-by > addition), which is why I asked where it came from. > > We can add these, but for some reason the upstream maintainer did not > when applying it to their trees, so it's up to you if you want to dig up > the information like this or not, it's not a trivial task at times. > > thanks, > > greg k-h > Very thanks for your opinion. I will sent v3. -- Regards Chen Jun
