Re: [PATCH] ARM: crypto: comment out gcc warning that breaks clang builds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 31 Jul 2022 at 12:05, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> The gcc build warning prevents all clang-built kernels from working
> properly, so comment it out to fix the build.
>
> This is a -stable kernel only patch for now, it will be resolved
> differently in mainline releases in the future.
>
> Cc: "Jason A. Donenfeld" <Jason@xxxxxxxxx>
> Cc: "Justin M. Forbes" <jforbes@xxxxxxxxxxxxxxxxx>
> Cc: Ard Biesheuvel <ardb@xxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxxxx>
> Cc: Nicolas Pitre <nico@xxxxxxxxxx>
> Cc: Nathan Chancellor <nathan@xxxxxxxxxx>
> Cc: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  arch/arm/lib/xor-neon.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/lib/xor-neon.c b/arch/arm/lib/xor-neon.c
> index b99dd8e1c93f..7ba6cf826162 100644
> --- a/arch/arm/lib/xor-neon.c
> +++ b/arch/arm/lib/xor-neon.c
> @@ -26,8 +26,9 @@ MODULE_LICENSE("GPL");
>   * While older versions of GCC do not generate incorrect code, they fail to
>   * recognize the parallel nature of these functions, and emit plain ARM code,
>   * which is known to be slower than the optimized ARM code in asm-arm/xor.h.
> + *
> + * #warning This code requires at least version 4.6 of GCC
>   */
> -#warning This code requires at least version 4.6 of GCC
>  #endif
>
>  #pragma GCC diagnostic ignored "-Wunused-variable"

LGTM but doesn't Clang also complain about the GCC specific pragma?



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux