On 7/25/22 02:32, Alistair Popple wrote:
Ralph Campbell <rcampbell@xxxxxxxxxx> writes:
If hmm_range_fault() is called with the HMM_PFN_REQ_FAULT flag and a
device private PTE is found, the hmm_range::dev_private_owner page is
used to determine if the device private page should not be faulted in.
However, if the device private page is not owned by the caller,
hmm_range_fault() returns an error instead of calling migrate_to_ram()
to fault in the page.
/*
* Never fault in device private pages, but just report
* the PFN even if not present.
*/
This comment needs updating because it will be possible to fault in
device private pages now.
It also looks a bit strange to be checking for device private entries
twice - I think it would be clearer if hmm_is_device_private_entry() is
removed and the ownership check done directly in hmm_vma_handle_pte().
- Alistair
I'll fix this in v2. Thanks for the review.
