Re: [PATCH stable 4.14 v3] net: dsa: bcm_sf2: force pause link settings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/12/22 12:18, Greg Kroah-Hartman wrote:
On Thu, Jul 07, 2022 at 05:14:05PM -0700, Florian Fainelli wrote:
From: Doug Berger <opendmb@xxxxxxxxx>

commit 7c97bc0128b2eecc703106112679a69d446d1a12 upstream

The pause settings reported by the PHY should also be applied to the
GMII port status override otherwise the switch will not generate pause
frames towards the link partner despite the advertisement saying
otherwise.

Fixes: 246d7f773c13 ("net: dsa: add Broadcom SF2 switch driver")
Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>
Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Link: https://lore.kernel.org/r/20220623030204.1966851-1-f.fainelli@xxxxxxxxx
Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
---
Changes in v3:

- gate the flow control enabling to links that are auto-negotiated and
   in full duplex


Are these versions better / ok now?

Vladimir "soft" acked it when posting the v3 to v2 incremental diff here:

https://lore.kernel.org/stable/20220707221537.atc4b2k7fifhvaej@skbuf/

so yes, these are good now. Thanks and sorry for the noise.
--
Florian



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux