On Tue, 12 Jul 2022 19:48:44 +0800 Zheng Yejian <zhengyejian1@xxxxxxxxxx> wrote: > Since I'm not very familiar with trace_events_hist.c, I roughly conclude that: > 1. warning 1/3/6 are plausible but false-positive; > 2. warning 2/4/5 seems positive although they don't cause practical problems because > elt_data->field_var_str[i] / ref_field->system / ref_field->name can be 'NULL' > on 'kfree'. Do we need to explicitly check 'NULL' there? It's confusing code. Both Tom and I missed it as well. -- Steve
