Re: [PATCH v2] usb: typec: add missing uevent when partner support PD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fri, Jul 01, 2022 at 04:08:54PM +0800, Linyu Yuan kirjoitti:
> System like Android allow user control power role from UI, it is possible
> to implement application base on typec uevent to refresh UI, but found
> there is chance that UI show different state from typec attribute file.
> 
> In typec_set_pwr_opmode(), when partner support PD, there is no uevent
> send to user space which cause the problem.
> 
> Fix it by sending uevent notification when change power mode to PD.
> 
> Fixes: bdecb33af34f ("usb: typec: API for controlling USB Type-C Multiplexers")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Linyu Yuan <quic_linyyuan@xxxxxxxxxxx>

Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
> v2: (v1 https://lore.kernel.org/linux-usb/1656637315-31229-1-git-send-email-quic_linyyuan@xxxxxxxxxxx/)
>     fix review comment from Greg,
>     add Fixes tag,
>     improve commit description.
> 
>  drivers/usb/typec/class.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index bbc46b1..3da94f712 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1851,6 +1851,7 @@ void typec_set_pwr_opmode(struct typec_port *port,
>  			partner->usb_pd = 1;
>  			sysfs_notify(&partner_dev->kobj, NULL,
>  				     "supports_usb_power_delivery");
> +			kobject_uevent(&partner_dev->kobj, KOBJ_CHANGE);
>  		}
>  		put_device(partner_dev);
>  	}
> -- 
> 2.7.4

-- 
heikki



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux