On Tue, Jul 12, 2022 at 4:37 AM Kent Gibson <warthog618@xxxxxxxxx> wrote: > > On Mon, Jul 11, 2022 at 07:34:18PM +0200, Bartosz Golaszewski wrote: > > The chip_name configs attribute always displays the device name of the > > first GPIO bank because the logic of the relevant function is simply > > wrong. > > > > Fix it by correctly comparing the bank's swnode against the GPIO > > device's children. > > > > That works for me, so thanks for that. > > Not totally convinced by Andy's suggestion to rename swnode to fwnode. > Variables should be named for what they represent, not their type, and > you use swnode extensively elsewhere in the module, so either change it > everywhere or not at all, and such a sweeping change is beyond the scope > this patch. > > Though it may make his other suggestion to use device_match_fwnode() > read a little better. No issue with that suggestion. > > Cheers, > Kent. I agree on device_match_fwnode() and disagree on the swnode rename. v2 sent out. Bart
