On Tue, Jul 05, 2022 at 02:34:57AM +0300, Vladimir Oltean wrote:
> Hi Florian,
>
> On Mon, Jul 04, 2022 at 08:35:07AM -0700, Florian Fainelli wrote:
> > From: Doug Berger <opendmb@xxxxxxxxx>
> >
> > commit 7c97bc0128b2eecc703106112679a69d446d1a12 upstream
> >
> > The pause settings reported by the PHY should also be applied to the GMII port
> > status override otherwise the switch will not generate pause frames towards the
> > link partner despite the advertisement saying otherwise.
> >
> > Fixes: 246d7f773c13 ("net: dsa: add Broadcom SF2 switch driver")
> > Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>
> > Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> > ---
> > drivers/net/dsa/bcm_sf2.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
> > index 40b3adf7ad99..03f38c36e188 100644
> > --- a/drivers/net/dsa/bcm_sf2.c
> > +++ b/drivers/net/dsa/bcm_sf2.c
> > @@ -671,6 +671,11 @@ static void bcm_sf2_sw_adjust_link(struct dsa_switch *ds, int port,
> > reg |= LINK_STS;
> > if (phydev->duplex == DUPLEX_FULL)
> > reg |= DUPLX_MODE;
> > + if (phydev->pause) {
> > + if (phydev->asym_pause)
> > + reg |= TXFLOW_CNTL;
> > + reg |= RXFLOW_CNTL;
> > + }
>
> Is this correct? phydev->pause and phydev->asym_pause keep the Pause and
> Asym_Pause bits advertised by the link partner. In other words, in this
> manual resolution you are ignoring what the local switch port has
> advertised.
linkmode_resolve_pause() is not used yet outside of phylink, but
should help here.
Andrew
