On Fri, Jul 1, 2022 at 5:41 AM Nishanth Menon <nm@xxxxxx> wrote: > On 18:01-20220630, Nishanth Menon wrote: ... > > static const struct of_device_id adc128_of_match[] = { > > - { .compatible = "ti,adc128s052", }, > > - { .compatible = "ti,adc122s021", }, > > - { .compatible = "ti,adc122s051", }, > > - { .compatible = "ti,adc122s101", }, > > - { .compatible = "ti,adc124s021", }, > > - { .compatible = "ti,adc124s051", }, > > - { .compatible = "ti,adc124s101", }, > > + { .compatible = "ti,adc128s052", .data = 0}, > > I should probably cast these as .data = (void *)0 thoughts? The 0 is default. You shouldn't use that in the first place for something meaningful rather than "no, we have no driver data for this chip). -- With Best Regards, Andy Shevchenko