Re: [PATCH 1/1] usb: ehci: using wIndex + 1 for hub port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 4 Aug 2014, Peter Chen wrote:

> The roothub's index per controller is from 0, but the hub port index per hub
> is from 1, this patch fixes "can't find device at roohub" problem for connecting
> test fixture at roohub when do USB-IF Embedded Host High-Speed Electrical Test.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> ---
>  drivers/usb/host/ehci-hub.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
> index cc305c7..b82e74a 100644
> --- a/drivers/usb/host/ehci-hub.c
> +++ b/drivers/usb/host/ehci-hub.c
> @@ -1230,7 +1230,7 @@ int ehci_hub_control(
>  			if (selector == EHSET_TEST_SINGLE_STEP_SET_FEATURE) {
>  				spin_unlock_irqrestore(&ehci->lock, flags);
>  				retval = ehset_single_step_set_feature(hcd,
> -									wIndex);
> +									wIndex + 1);

Instead of violating the 80-column rule, you should reduce the 
excessive indentation on the continued line.

Apart from that,

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]