Re: [PATCH] platform_get_irq: Revert to platform_get_resource if of_irq_get fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 29, 2014 at 06:21:31PM -0700, Guenter Roeck wrote:
> On 07/29/2014 06:11 PM, Greg KH wrote:
> >On Tue, Jul 29, 2014 at 05:40:02PM -0700, Guenter Roeck wrote:
> >>Upstream commit: aff008ad813c7cf3cfe7b532e7ba2c526c136f22
> >>
> >>Commits 9ec36ca (of/irq: do irq resolution in platform_get_irq)
> >>and ad69674 (of/irq: do irq resolution in platform_get_irq_byname)
> >>change the semantics of platform_get_irq and platform_get_irq_byname
> >>to always rely on devicetree information if devicetree is enabled
> >>and if a devicetree node is attached to the device. The functions
> >>now return an error if the devicetree data does not include interrupt
> >>information, even if the information is available as platform resource
> >>data.
> >>
> >>This causes mfd client drivers to fail if the interrupt number is
> >>passed via platform resources. Therefore, if of_irq_get fails, try
> >>platform_get_resource as method of last resort. This restores the
> >>original functionality for drivers depending on platform resources
> >>to get irq information.
> >>
> >>Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> >>Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> >>Cc: Grant Likely <grant.likely@xxxxxxxxxx>
> >>Cc: Grygorii Strashko <grygorii.strashko@xxxxxx>
> >>Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> >>Acked-by: Rob Herring <robh@xxxxxxxxxx>
> >>Cc: stable <stable@xxxxxxxxxxxxxxx>
> >>Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >>[ Guenter Roeck: backported to 3.15 ]
> >>Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> >>---
> >>  drivers/base/platform.c | 9 +++++++--
> >>  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> >This should also go to 3.14 and 3.10, right?
> >
> 
> Definitely 3.14, as this is where I hit it. 3.10 only if you applied 9ec36ca
> to it (or if you plan to apply it). I don't see it there, so at least not yet.

Ok, I'll just add it to 3.14, thanks.  It looks like
9ec36cafe43bf835f8f29273597a5b0cbc8267ef was asked to be backported to
3.10, but never made it, which turns out to be good :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]